Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ri =d20这种语法不起效,以及.st技能相关问题 #905

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

fy0
Copy link
Member

@fy0 fy0 commented Jul 11, 2024

Fix #901
Fix #903
Fix #907

Copy link
Member

@Xiangze-Li Xiangze-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

基于实测效果,变化值的表示是有问题的。

这里表示成白值的变化(0→1)可能是较好的,如果不方便的话总值(7→8)也能接受

image

@Xiangze-Li
Copy link
Member

@MintCider 你的修改看起来并不直接依赖此处的修改,考虑单独开一个 PR,可以快速合并

@MintCider
Copy link
Contributor

主要是我不是很确定该向哪里 Merge,现在有 masterdevdevelop-1.5.0

@Xiangze-Li
Copy link
Member

主要是我不是很确定该向哪里 Merge,现在有 masterdevdevelop-1.5.0

你的修改是修复150版本重新DnD造成的bug,指向master

@fy0
Copy link
Member Author

fy0 commented Jul 15, 2024

进行了调整
image

@Xiangze-Li Xiangze-Li merged commit ef8e756 into master Jul 15, 2024
3 checks passed
@Xiangze-Li Xiangze-Li deleted the fix/dnd5e-v150-issues-v2 branch July 15, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants