fix: Hide border on DetailRow:last-of-type
#596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xplato
requested review from
razor-x,
mikewuu,
dawnho and
Andrewjeska
as code owners
razor-x
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the border of the last
DetailRowwould be visible. This is because the SCSS uses the:not(:last-of-type)selector, which operates on element type. To fix it, we needed to make sure thatDetailRowwas the lastdivin any given childdiv. This PR simply wraps those two exceptional elements in an intermediarydiv.Before
Under "Fan mode" and "Allow manual override"
After