fix: use dynamic images as image size too large #619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawnho
approved these changes
Apr 30, 2024
razor-x
requested changes
Apr 30, 2024
There was a problem hiding this comment.
Note this is a test branch to verify the solution. The optimized URLs will be returned from the API with no update needed to this project. Blocking to avoid accidental merge.
Currently, the images do not load with this change: https://react-ka4irjlds.seam.vc/examples/basic/
razor-x
reviewed
May 1, 2024
vercel.json
Outdated
| @@ -84,7 +84,7 @@ | |||
| "headers": [ | |||
| { | |||
| "key": "Content-Security-Policy", | |||
| "value": "default-src 'self'; connect-src 'self' https://connect.getseam.com; img-src 'self' https://connect.getseam.com; font-src 'self' https://fonts.gstatic.com; style-src 'self' https://fonts.googleapis.com" | |||
| "value": "default-src 'self'; connect-src 'self' https://connect.getseam.com; img-src 'self' https://connect.getseam.com https://console.seam.co; font-src 'self' https://fonts.gstatic.com; style-src 'self' https://fonts.googleapis.com" | |||
There was a problem hiding this comment.
This is going to be an issue. If we suddenly change image hosts we will break consumers using CSP.
|
closing as handled via https://github.com/seamapi/seam-connect/pull/6866 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #616
This is a POC. We'll use Next.js'
_next/imagedirectly to get a dynamic image size.Before
After
webpas expectedLive storybook
https://react.seam.co/?path=/docs/components-devicetable--docs
I replaced the
srcattribute, and it's quite a big difference.