Adds unmanaged device resource and client #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AxelTheGerman
requested review from
seveibar,
abimaelmartell and
andrii-balitskyi
as code owners
seveibar
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
looks right to me! @andrii-balitskyi want to take a quick look
seveibar
previously approved these changes
Jun 12, 2023
There was a problem hiding this comment.
looks right to me! @andrii-balitskyi want to take a quick look
AxelTheGerman
force-pushed
the
unmanaged-devices
branch
from
bba4552
to
eb49b7b
Compare
razor-x
approved these changes
Jun 12, 2023
|
Actually looks like this addresses #44 (not sure if fully) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Ruby classes for unmanaged devices:
I basically copied the
devicescode and adapted it to the unmanaged version - which basically has less information. I'm not sure if it has apropertieshash as well (looks like it from my initial testing in the console).