Grib backport #111

did-g · 2017-12-26T17:26:21Z

Hi,

backport unrelated stuff from grib plugin record so grib and weather_routing source code don't diverge to much.
use new grib class format once, or if, integrated in opencpn.
use smart pointers and a weakly referenced grib record table for sharing grib record between configurations, if it's committed, it needs some cleanup, this commit trying to change as little as possible code.

I'm hijacking plugin API version for testing grib record format change...

For testing on linux adding plugins as subtree is the easiest. My default branch https://github.com/did-g/OpenCPN.git have a bunch of subtree plugins , may have too much unrelated WIP changes though.

Regards
Didier

rgleason · 2017-12-27T18:02:04Z

Did-g, can I make a pr and merge, and it will work? It sounds like Sean needs to do some additional programming, and we will need a new api115. No problem there, but doesn't OpenCPN Alpha needs to have it too?

did-g · 2017-12-27T18:39:25Z

Hi,
API version 115 is already in Dave's master branch but you need both ocpn and weather routing PR pull/merge .

Unless you are trying to compute route with big grib or very small time steps (ie many interpolated records) this PR have no visible change.

I wouldn't spend time on it.

Regards
Didier

rgleason · 2017-12-27T20:27:42Z

Thanks, I am using th Alpha version now, so I guess I'll merge it next time, or when Sean does.

seandepagnier · 2017-12-30T00:11:44Z

Are there any measured performance improvements from shared pointers here?

Is this safe to merge... will it be compatible with older grib plugins, or do we need to check the grib plugin version?

did-g · 2017-12-30T17:45:42Z

Hi,
There's a small speed improvement but the main advantage is that on a 32 bits system for big gribs without sharing records weather_routing reach 4 GB limit a lot earlier.
By using less memory there's another improvement even on 64 bits system:
Currently opencpn purges its charts cache if the whole process memory is closed to a 1 GB limit.
Even without very big grib or a lot of computed routes it can really slowdown opencpn to a point where restarting opencpn is the only option left.

This version isn't compatible with 4.8.0 there's no need for testing because API version 115 is not release yet and this version will fail to load on 4.8.0 or older.

If you want to release a new weather_routing version for released O version don't merge this PR.

seandepagnier · 2017-12-30T19:13:14Z

You must be using full world gribs or very high resolution? What is your source of gribs? Maybe the plugin could request subsets of grib files to reduce the memory load as well? I _may_ release a new version soon, so I will hang onto this PR for nwo.

…

On 12/30/17, didier ***@***.***> wrote: Hi, There's a small speed improvement but the main advantage is that on a 32 bits system for big gribs without sharing records weather_routing reach 4 GB limit a lot earlier. By using less memory there's another improvement even on 64 bits system: Currently opencpn purges its charts cache if the whole process memory is closed to a 1 GB limit. Even without very big grib or a lot of computed routes it can really slowdown opencpn to a point where restarting opencpn is the only option left. This version isn't compatible with 4.8.0 there's no need for testing because API version 115 is not release yet and this version will fail to load on 4.8.0 or older. If you want to release a new weather_routing version for released O version don't merge this PR. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #111 (comment)

did-g · 2017-12-30T19:34:50Z

My grib source? The best, me :)

I'm using Meteo France for hourly wind 0.01° and IFREMER for 15 mn current 0.0023° .
for example:
http://195.154.231.142/IFREMER/MANW250.grb
it's a 60MB for a 4x2 degrees 15 hours...

I'm having fun trying to find if it's worth it.

seandepagnier · 2018-01-30T04:03:13Z

There was no release, so I am ready to merge this, if you can resolve the conflicts.

did-g · 2018-02-01T19:01:06Z

Hi,
This PR is not compatible with current OpenCPN record format.

I'm pushing a second change with only gribrecord modifications since previous copy and paste gribrecord code in weather routing, if you commit this PR I will update this one (still trying to find a way to stay compatible with current OpenCPN).

Regards
Didier

seandepagnier · 2018-02-08T05:48:13Z

I will merge if you can resolve conflicts.

seandepagnier · 2018-02-09T16:29:12Z

ok. waiting until opencpn (in git master) is ready.

rgleason · 2018-02-09T19:00:43Z

What was this PR #132 Grib BackportV2 Grib record changes from Opencpn for?
078c4d1

Should this one be closed because it is old?

did-g · 2018-02-11T12:44:31Z

Weather routing is using some files from Opencpn main source code, by copying them. In 4.8.2 theses files have been slightly modified without breaking compatibility with older versions. #132 copy back them in weather routing. It's not a mandatory change but by keeping both versions as close as possible it'd make life easier down the line; both for understanding code and in the case some incompatible changes have to be made.

…

On Fri, Feb 9, 2018 at 8:00 PM, Rick Gleason ***@***.***> wrote: What was this PR #132 <#132> Grib Backport Grib record changes from Opencpn for? 078c4d1 <078c4d1> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#111 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALk2KmjcesvK9p47SLG9qo7xvaV2xAh4ks5tTJXcgaJpZM4RM5rJ> .

rgleason · 2018-03-22T16:49:25Z

On Feb 8 Sean merged #133 Error in Boundary which keeps compatibility with 4.8.2 and earlier.

On Dec 30,2017 Did-g wrote:

This version isn't compatible with 4.8.0 there's no need for testing because API version 115 is not release yet and this version will fail to load on 4.8.0 or older.
If you want to release a new weather_routing version for released O version don't merge this PR.

So I believe that Grib Backport #111 this should not be merged until we move on to wxWidgets 3.1.1 and working at the head on API 16 and v4.99.

seandepagnier · 2019-02-07T05:06:32Z

Is this ready to merge or should we wait for O5 release?

did-g · 2019-02-07T11:52:31Z

Hi, It's missing O5 Appveyor dependencies but otherwise yes it's ready to merge.

…

On Thu, Feb 7, 2019 at 6:06 AM seandepagnier ***@***.***> wrote: Is this ready to merge or should we wait for O5 release? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#111 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALk2KlXGPHbEzMe2O8Ra10xCdfidNav4ks5vK7RYgaJpZM4RM5rJ> .

did-g · 2019-02-14T12:54:03Z

Hi,
Should have right dependencies for Windows and OSX CI build.

did-g force-pushed the grib_backport branch from 5cd03e7 to a079e28 Compare February 2, 2018 07:54

did-g force-pushed the grib_backport branch from a079e28 to 9cff2cb Compare February 9, 2018 09:44

did-g mentioned this pull request Feb 9, 2018

Error in boundary #133

Merged

did-g force-pushed the grib_backport branch from 9cff2cb to 18cee16 Compare April 6, 2018 11:44

did-g added 2 commits January 29, 2019 06:59

backport GribRecord changes from OpenCPN

742d191

bump plugin API to 115 for new grib records format

32ac001

did-g force-pushed the grib_backport branch from 18cee16 to 32ac001 Compare January 30, 2019 18:19

update OSX Packager to 1.2.5 version

dad0943

did-g force-pushed the grib_backport branch from 931ab0e to 350fc97 Compare February 10, 2019 17:20

Windows Wx 3.1.2 zlib

cebcd1a

did-g force-pushed the grib_backport branch from 350fc97 to cebcd1a Compare February 10, 2019 23:59

Update OSX travis build with navnux's MacOS 10.9 wx 3.1.2

e9aaaa8

seandepagnier merged commit 4358838 into seandepagnier:master Feb 14, 2019

did-g deleted the grib_backport branch February 15, 2019 00:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Grib backport #111

Grib backport #111

did-g commented Dec 26, 2017

rgleason commented Dec 27, 2017

did-g commented Dec 27, 2017

rgleason commented Dec 27, 2017

seandepagnier commented Dec 30, 2017

did-g commented Dec 30, 2017

seandepagnier commented Dec 30, 2017 via email

did-g commented Dec 30, 2017

seandepagnier commented Jan 30, 2018

did-g commented Feb 1, 2018

seandepagnier commented Feb 8, 2018

seandepagnier commented Feb 9, 2018

rgleason commented Feb 9, 2018 •

edited

Loading

did-g commented Feb 11, 2018 via email

rgleason commented Mar 22, 2018 •

edited

Loading

seandepagnier commented Feb 7, 2019

did-g commented Feb 7, 2019 via email

did-g commented Feb 14, 2019

Grib backport #111

Grib backport #111

Conversation

did-g commented Dec 26, 2017

rgleason commented Dec 27, 2017

did-g commented Dec 27, 2017

rgleason commented Dec 27, 2017

seandepagnier commented Dec 30, 2017

did-g commented Dec 30, 2017

seandepagnier commented Dec 30, 2017 via email

did-g commented Dec 30, 2017

seandepagnier commented Jan 30, 2018

did-g commented Feb 1, 2018

seandepagnier commented Feb 8, 2018

seandepagnier commented Feb 9, 2018

rgleason commented Feb 9, 2018 • edited Loading

did-g commented Feb 11, 2018 via email

rgleason commented Mar 22, 2018 • edited Loading

seandepagnier commented Feb 7, 2019

did-g commented Feb 7, 2019 via email

did-g commented Feb 14, 2019

rgleason commented Feb 9, 2018 •

edited

Loading

rgleason commented Mar 22, 2018 •

edited

Loading