Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

fix(resolver): Recursive types nested within containers caused a recursion error #137

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

seandstewart
Copy link
Owner

We were pre-emptively clearing the stack when calling Resolver.resolve() - we should only clear the stack once resolution is complete.

This resolves #136

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #137 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   93.81%   93.81%           
=======================================
  Files          36       36           
  Lines        3866     3866           
=======================================
  Hits         3627     3627           
  Misses        239      239           
Flag Coverage Δ
#3.8 93.81% <100.00%> (ø)
#unittests 93.81% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
typic/serde/resolver.py 94.91% <100.00%> (-0.43%) ⬇️
typic/serde/common.py 96.38% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b918cc...087e348. Read the comment docs.

@seandstewart seandstewart self-assigned this Oct 30, 2020
@seandstewart seandstewart added the bug Something isn't working label Oct 30, 2020
@seandstewart seandstewart merged commit df2f8e0 into main Oct 30, 2020
@seandstewart seandstewart deleted the 136/recursive-type-with-container branch January 5, 2021 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recursive type with List[] causing RecursionError
1 participant