Add --max-snapshots option #35
Conversation
|
@Lightjohn Thanks for your pull request, it works! I've done a few small fixes to it on this branch:
There's a couple more things that I'd like to fix before merging this. I'll add comments to them inline in this pull request. Could you pull this branch into your branch, make these fixes, then push to your original branch? I'd also like to add tests for the new |
| @@ -378,6 +394,13 @@ def snapshot(source, dest, debug=False, min_snapshots=3, extra_args=None): | |||
| """ | |||
| date = _datetime() | |||
| user, host, snapshots_root = _parse_path(dest) | |||
| if max_snapshots > -1 and max_snapshots - min_snapshots < 0: | |||
There was a problem hiding this comment.
Could ...and max_snapshots - min_snapshots < 0 just be and max_snapshots < min_snapshots?
There was a problem hiding this comment.
I was thinking about that but I think both ways are good, I can't see counter example at this point.
|
OK for me as it's cross version (that what not the case for sys.maxint). I add it and made some tests and it should be good. |
|
Hey John, I got really busy, I promise I'll get back to you on this when I can |
|
No problem, take your times. I have the code and it's working so no Le 23/02/2016 12:46, Sean Hammond a écrit :
|
No description provided.