Make redirect::AsLocation public #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Sealed trait it inherits from is still private to this mod, so users are still unable to impl AsLocation for other types, but can now see documentation for the AsLocation trait and its implementors
jxs
approved these changes
Jun 8, 2021
|
Hi and thanks for the PR! Even the trait keeps sealed for implementation it's now open to use on type's and function signatures, thou I think it's ok in this case 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables documentation while still keeping the trait sealed outside of the
redirectmod. Here's what the docs now look like: