WIP: Add cors filter #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
It'd be wonderful to cross-reference with the implementation in tower-web. Since the plan is to merge the projects, having "close enough" code is probably a desirable goal. |
|
If nothing else, you might benefit from the testcases there and may find bugs in that implementation we can fix. |
|
@shepmaster Thanks for sharing. I'll check it out. |
|
One thing to figure out: What should be a filter vs. what should be a middleware? It actually seems that Filter is more general, so it is possible that middleware could be adapted into a filter, so that there can be a generic "middleware" filter. |
|
I'm closing this for now until there would be a better understanding of warp relation to tower-web. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for the issue. Work in progress.