Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy warnings #894

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Fix clippy warnings #894

merged 1 commit into from
Sep 10, 2021

Conversation

nickelc
Copy link
Contributor

@nickelc nickelc commented Sep 9, 2021

clippy::from_over_into
clippy::match_like_matches_macro
clippy::needless_borrow
clippy::option_as_ref_deref
clippy::redundant_closure
clippy::single_component_path_imports
clippy::useless_conversion

@nickelc
Fix clippy warnings
40c7255 
clippy::from_over_into
clippy::match_like_matches_macro
clippy::needless_borrow
clippy::option_as_ref_deref
clippy::redundant_closure
clippy::single_component_path_imports
clippy::useless_conversion
kaj
kaj approved these changes Sep 10, 2021
View reviewed changes
Copy link

@kaj kaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all looks like improvements to me (though I'm not a maintainer).

seanmonstar
seanmonstar approved these changes Sep 10, 2021
View reviewed changes
Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@seanmonstar seanmonstar merged commit 79e7bba into seanmonstar:master Sep 10, 2021
@nickelc nickelc deleted the clippy-warnings branch September 10, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaj kaj kaj approved these changes

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickelc @seanmonstar @kaj