Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test example so it doesn't fail #988

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

vargad
Copy link
Contributor

@vargad vargad commented Aug 12, 2022

Comment says "Or simply test if a request matches (doesn't reject)"
therefore I would expect for assert to test for success. Also this
example (for sum) will always match. It's confusing the code example
actually tests if it doesn't match.

Comment says "Or simply test if a request matches (doesn't reject)"
therefore I would expect for assert to test for success. Also this
example (for sum) will always match. It's confusing the code example
actually tests if it doesn't match.
@jxs jxs merged commit 3cf1783 into seanmonstar:master Aug 12, 2022
@jxs
Copy link
Collaborator

jxs commented Aug 12, 2022

Hi,
yeah this makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants