Toolbar Menu not showing #47
Comments
|
Thanks for taking the time to file an issue! I realize my issue template forgot to ask -- what version of the extension is this? I've seen something like this occasionally and have had difficulty tracking it down. Does this happen often/always? Does it work if you give it a couple seconds and/or close/reopen the popup, or is it just broken forever? |
|
Hey. And it's like that since I installed the addon a couple of months ago. (I replaced SynoLoader addon with yours, since that is legacy kind.) It's showing the download task number on the icon, and new download tasks can be added through the context menu, but that's it. The menu never shows. |
|
Huh, that's very strange. I've just published a new version (0.4.0) today that should improve the error handling for this -- if it hits an unrecoverable/unknown error, it'll display an "uh oh everything is a disaster" page with some debugging information. When you have a chance can you give the new version a try and see if it shows you something useful? |
|
No problem! Here is the debug info: I guess it would be nice seeing that number attribute that is not a number... |
|
Looks like the problematic call is passing I notice you have DSM 5, so it's conceivable that your NAS is returning (e.g.) a number in string form (or something else entirely), though I've hardcoded the API versions I use so that would be a proper bug on Synology's part if my NAS behaved differently from yours there. The documentation for the If you want to see something, you could try opening the settings and hiding "completed, uploading" tasks from view as they seem to have the problematic value (though I suppose tasks in other states could also exhibit this problem, and hiding all task types isn't terribly useful).
EDIT: Actually, the size of the task doesn't matter. What matters is if you've only uploaded less than 1024 bytes, which is entirely possible with any task. |
|
First, thanks for the lengthy explanation. I have both downloading and seeding tasks with 0 uploaded bytes. So the menu only works if I disable all task types. 😄 If you can help me how, I'd be happy to dig out whatever data my NAS sends. What is still weird though, that no one else reported this issue. |
|
Agreed it is weird, which is part of why I'm thinking that it might be a DSM 5 thing. I appreciate you offering to help! This would be extraordinarily hard to debug otherwise since I don't have access to DSM 5. If you're willing to take a journey into the Firefox dev tools, the information I need can be found by doing the following:
|
|
Here it is, cleaned & formatted. {
"data":{
"offeset":0,
"tasks":[
{
"additional":{
"detail":{
"connected_leechers":0,
"connected_seeders":0,
"create_time":"1491422337",
"destination":"download",
"priority":"auto",
"total_peers":0,
"uri":"xxxxxxxxxxxxxxxxxxxxx.torrent"
},
"transfer":{
"size_downloaded":"0",
"size_uploaded":"0",
"speed_download":0,
"speed_upload":0
}
},
"id":"dbid_2773",
"size":"2411334039",
"status":"downloading",
"status_extra":null,
"title":"xxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
"type":"bt",
"username":"admin"
},
{
"additional":{
"detail":{
"connected_leechers":0,
"connected_seeders":0,
"create_time":"1510448409",
"destination":"download",
"priority":"auto",
"total_peers":0,
"uri":"magnet:?xt=urn:btih:1a322exxxxxxxxxxxxxxxxxxxx"
},
"transfer":{
"size_downloaded":"267047174",
"size_uploaded":"0",
"speed_download":0,
"speed_upload":0
}
},
"id":"dbid_3436",
"size":"604639494",
"status":"downloading",
"status_extra":null,
"title":"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
"type":"bt",
"username":"admin"
},
{
"additional":{
"detail":{
"connected_leechers":0,
"connected_seeders":0,
"create_time":"1510606025",
"destination":"download",
"priority":"auto",
"total_peers":0,
"uri":"6a070ed2d69796eeb7c8a14594b29495.torrent"
},
"transfer":{
"size_downloaded":"0",
"size_uploaded":"0",
"speed_download":0,
"speed_upload":0
}
},
"id":"dbid_3446",
"size":"131418360",
"status":"downloading",
"status_extra":null,
"title":"6a070ed2d69796eeb7c8a14594b29495",
"type":"bt",
"username":"admin"
},
{
"additional":{
"detail":{
"connected_leechers":0,
"connected_seeders":0,
"create_time":"1510849245",
"destination":"download",
"priority":"auto",
"total_peers":0,
"uri":"bab6ce7ef8a3380da674397d50815c41.torrent"
},
"transfer":{
"size_downloaded":"201631352",
"size_uploaded":"87783002",
"speed_download":0,
"speed_upload":0
}
},
"id":"dbid_3451",
"size":"201631352",
"status":"seeding",
"status_extra":null,
"title":"bab6ce7ef8a3380da674397d50815c41",
"type":"bt",
"username":"admin"
},
{
"additional":{
"detail":{
"connected_leechers":0,
"connected_seeders":0,
"create_time":"1510849245",
"destination":"download",
"priority":"auto",
"total_peers":0,
"uri":"4cf4002f00f31d52cb9540284d839cee.torrent"
},
"transfer":{
"size_downloaded":"162133184",
"size_uploaded":"0",
"speed_download":0,
"speed_upload":0
}
},
"id":"dbid_3452",
"size":"162133184",
"status":"seeding",
"status_extra":null,
"title":"4cf4002f00f31d52cb9540284d839cee",
"type":"bt",
"username":"admin"
},
{
"additional":{
"detail":{
"connected_leechers":0,
"connected_seeders":0,
"create_time":"1510953043",
"destination":"download",
"priority":"auto",
"total_peers":0,
"uri":"137bf27953d8d246388d5238ccda4946.torrent"
},
"transfer":{
"size_downloaded":"180797064",
"size_uploaded":"57274721",
"speed_download":0,
"speed_upload":0
}
},
"id":"dbid_3453",
"size":"180797064",
"status":"seeding",
"status_extra":null,
"title":"137bf27953d8d246388d5238ccda4946",
"type":"bt",
"username":"admin"
},
{
"additional":{
"detail":{
"connected_leechers":0,
"connected_seeders":0,
"create_time":"1510953044",
"destination":"download",
"priority":"auto",
"total_peers":0,
"uri":"a2f507a209b4d9b0a37de3c3f2ca7b32.torrent"
},
"transfer":{
"size_downloaded":"155822392",
"size_uploaded":"0",
"speed_download":0,
"speed_upload":0
}
},
"id":"dbid_3454",
"size":"155822392",
"status":"seeding",
"status_extra":null,
"title":"a2f507a209b4d9b0a37de3c3f2ca7b32",
"type":"bt",
"username":"admin"
},
{
"additional":{
"detail":{
"connected_leechers":0,
"connected_seeders":0,
"create_time":"1511037695",
"destination":"download",
"priority":"auto",
"total_peers":0,
"uri":"magnet:?xt=urn:btih:4bcxxxxxxxxxxxxxxxxxxxxxxxxxxx"
},
"transfer":{
"size_downloaded":"0",
"size_uploaded":"0",
"speed_download":0,
"speed_upload":0
}
},
"id":"dbid_3455",
"size":"0",
"status":"downloading",
"status_extra":null,
"title":"xxxxxxxxxxxxxxxxxxxxxxxx",
"type":"bt",
"username":"admin"
}
],
"total":8
},
"success":true
}BTW: While it's DSM5, it's actually the latest update of that (had some security patch a few days ago), so I'd say it still part of the supported line. I'm running some extra services using |
|
Yup, so it looks like this is a legitimate bug in DSM: you and I are using the the same version of the same API call, but I'm getting numerical types and you're sometimes getting strings, and it's not even self-consistent: "transfer":{
"size_downloaded":"0",
"size_uploaded":"0",
"speed_download":0,
"speed_upload":0
}(FWIW, the docs do say it should be a string, but this is the first I've ever seen that.) This should be easy to fix; it just requires special-casing this call to parse those strings into numbers. |
…or some values. See seansfkelley/nas-download-manager#47, where it was determined that the same API call + version combination yields different results (in terms of numbers being numbers or strings) between DSM versions, i.e., I'm working around a Synology bug.
|
Confirmed, works, thanks a million! |
|
Excellent, and thanks for helping debug! |
Versions
OS: Xubuntu 16.04
Browser and version: FF57 (was also in 56)
DSM version: DSM 5.2-5967 Update 6 (was also with Update 5)
Download Station version: 3.5-2985
Steps to Reproduce the Issue
It seems to be a very general issue, but since no one reported it so far, I guess I'm doing something wrong...
The text was updated successfully, but these errors were encountered: