Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor application layout (potential BREAKING CHANGE) #127

Merged
merged 6 commits into from
Jun 21, 2023

Conversation

seapagan
Copy link
Owner

@seapagan seapagan commented Jun 19, 2023

Move the main application code and modules into the app subdirectory of the root. This tidies up things a bit.

However, it may be a **BREAKING CHANGE** for those who have already customized the app.

Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@seapagan seapagan added enhancement New feature or request Refactor labels Jun 19, 2023
@seapagan seapagan self-assigned this Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #127 (779ace5) into main (14bc2be) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files          22       22           
  Lines         518      518           
=======================================
  Hits          508      508           
  Misses         10       10           
Impacted Files Coverage Δ
app/config/settings.py 100.00% <ø> (ø)
app/models/enums.py 100.00% <ø> (ø)
app/resources/config_error.py 83.33% <ø> (ø)
app/schemas/email.py 100.00% <ø> (ø)
app/schemas/examples.py 100.00% <ø> (ø)
app/schemas/request/auth.py 100.00% <ø> (ø)
app/schemas/response/auth.py 100.00% <ø> (ø)
app/config/helpers.py 100.00% <100.00%> (ø)
app/config/metadata.py 100.00% <100.00%> (ø)
app/database/db.py 100.00% <100.00%> (ø)
... and 12 more

Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@seapagan seapagan marked this pull request as ready for review June 21, 2023 09:25
@seapagan seapagan merged commit 11a2d86 into main Jun 21, 2023
@seapagan seapagan deleted the refactor-layout branch June 21, 2023 09:26
@seapagan seapagan added breaking and removed enhancement New feature or request Refactor labels Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant