-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When(done) not failing on callback error #25
Comments
Whoops! On Fri, Feb 21, 2014 at 5:04 AM, Ludwig Magnusson
|
Upon reviewing your code, I now understand why this doesn't work. It's because of an implementation detail in how given's specs map back to Jasmine's. There's an impedance mismatch that given has to deal with because a single Jasmine It might be that we just need to look for errors passed to |
I forgot to mention that I use |
Be wary of the it(done) style async, because it's been implemented totally separately by a bunch of test runners prior to its official introduction in jasmine 2.0. jasmine-given should work with any of them, but YMMV |
As an addendum to this, E.g.
will report 2 assertions and 0 failures. |
Ugh, this really should get fixed |
I don't completely understand this code yet, but I think this is a properly failing test on the https://github.com/neall/jasmine-given/commit/b9b0f575d27c622e0ee39d429d1469d7894cbab1 |
FWIW, it seems like any non-falsy value should fail a test, not just an error. Like |
True On Wed, Aug 12, 2015 at 10:25 AM Andrew Nichols notifications@github.com
|
I noticed that an error in a callback made in a
When
statement did not cause the test to fail. In my example below only one test will fail, the first one.The text was updated successfully, but these errors were encountered: