Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: clean xid when tm commit or rollback failed #1735

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Oct 9, 2019

Ⅰ. Describe what this PR did

fix bug #1734

Ⅱ. Does this pull request fix one issue?

fixes #1734

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #1735 into develop will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1735   +/-   ##
==========================================
  Coverage      48.35%   48.35%           
  Complexity      1858     1858           
==========================================
  Files            365      365           
  Lines          13325    13325           
  Branches        1652     1652           
==========================================
  Hits            6443     6443           
  Misses          6213     6213           
  Partials         669      669
Impacted Files Coverage Δ Complexity Δ
...java/io/seata/tm/api/DefaultGlobalTransaction.java 67.74% <50%> (ø) 15 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7f2f6...61f28e5. Read the comment docs.

@zjinlei zjinlei changed the title bugfix: when tm commit or rollback failed,xid need to be clean bugfix: clean xid when tm commit or rollback failed Oct 9, 2019
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the retry logic will be changed in the next pr.

@slievrly slievrly merged commit 78aeabb into apache:develop Oct 10, 2019
@zjinlei zjinlei deleted the bugfix/1734/cleanXid branch October 10, 2019 07:43
dangquocbang pushed a commit to dangquocbang/seata that referenced this pull request Oct 14, 2019
* 'develop' of https://github.com/seata/seata:
  test: enhance test coverage of seata common (apache#1755)
  security: upgrade jackson to avoid security vulnerabilities (apache#1756)
  bugfix:rm channel register null resource (apache#1401)
  bugfix:fix memory lock is not released due to hash conflict (apache#1751)
  optimize:use raw types instead of boxing types (apache#1747)
  change get charset (apache#1707)
  fix undo support oracle table meta cache (apache#1749)
  bugfix: fix use 'in' and 'between' in where condition for Oracle and Mysql (apache#1699)
  optimize:add some server's jvm parameters (apache#1738)
  Saga implementation base on state machine (apache#1608)
  optimize:inner class may be static (apache#1706)
  feature: retry when tm commit or rollback failed (apache#1739)
  optimize: abstract common undolog manager method (apache#1712)
  bugfix: when tm commit or rollback failed,xid need to be clean (apache#1735)
  optimize: eliminate the possibility of allocating too much direct memory (apache#1657)
  Based on Java 5 optimization (apache#1705)
  bugfix: oracle batch insert error (apache#1729)

# Conflicts:
#	pom.xml
@wangliang181230 wangliang181230 added this to the 0.9.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

io.seata.rm.tcc.interceptor.ActionInterceptorHandler 126 : TCC branch Register error
5 participants