-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: compatibility dubbo 2.7.4+ #2239
Conversation
bugfix: fix mysql connection unable to release (apache#2037)
optimize: gracefully close resources (apache#2139)
test: enhance test coverage of seata common (apache#2170)
Codecov Report
@@ Coverage Diff @@
## develop #2239 +/- ##
=============================================
+ Coverage 53.6% 53.74% +0.13%
Complexity 2620 2620
=============================================
Files 492 492
Lines 15395 15399 +4
Branches 1733 1765 +32
=============================================
+ Hits 8253 8276 +23
- Misses 6331 6335 +4
+ Partials 811 788 -23
|
integration/dubbo-alibaba/pom.xml
Outdated
@@ -39,5 +39,10 @@ | |||
<groupId>com.alibaba</groupId> | |||
<artifactId>dubbo</artifactId> | |||
</dependency> | |||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependence is not appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependence is not appropriate.
already modify @slievrly
|
||
@Override | ||
public Result invoke(Invoker<?> invoker, Invocation invocation) throws RpcException { | ||
if (DubboConstants.ALIBABADUBBO) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of dependence on seata-dubbo (apache-dubbo), is it alibaba-dubbo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of dependence on seata-dubbo (apache-dubbo), is it alibaba-dubbo?
used to determine whether it is Alibaba or Apache @slievrly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!DubboConstants.ALIBABADUBBO) {return invoker.invoke(invocation);}
reduce original changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!DubboConstants.ALIBABADUBBO) {return invoker.invoke(invocation);}
reduce original changes
get it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
modify dubbo filter class name,compatibility dubbo 2.7.4.1
Ⅱ. Does this pull request fix one issue?
fixes #2194