-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: optimize get table meta #2649
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2649 +/- ##
=============================================
- Coverage 51.20% 51.20% -0.01%
+ Complexity 2821 2820 -1
=============================================
Files 556 556
Lines 17833 17828 -5
Branches 2110 2109 -1
=============================================
- Hits 9132 9129 -3
+ Misses 7835 7833 -2
Partials 866 866
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Title can be clearer, such as removing redundant code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
optimize get table meta
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews