This repository has been archived by the owner on Aug 26, 2024. It is now read-only.
Fixed issue #59 - "partial" parameter for _token_set() is now honored
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this? |
|
fixed test which previously checked not partial comparison |
| @@ -129,7 +130,7 @@ def testTokenSetRatio(self): | |||
| self.assertEqual(fuzz.token_set_ratio(self.s4, self.s5), 100) | |||
|
|
|||
| def testPartialTokenSetRatio(self): | |||
| self.assertEqual(fuzz.token_set_ratio(self.s4, self.s5), 100) | |||
| self.assertEqual(fuzz.partial_token_set_ratio(self.s4, self.s7), 100) | |||
There was a problem hiding this comment.
Why not keep the old test as well?
There was a problem hiding this comment.
Because it didn't actually check partial_token_set_ratio? There is previous test to test token_set_ratio
josegonzalez
added a commit
that referenced
this pull request
Oct 22, 2014
Fixed issue #59 - "partial" parameter for `_token_set()` is now honored
|
Thanks for being patient! I'll make a release right now :) |
|
Thank you, you're the owner, may check as thoroughly as you please) |
|
Just made a release! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.