Fix minitest test_prelude

[flavorjones]

This PR addresses two issues:

1. In lib/hoe/test.rb, the use of self.test_prelude within a Minitest::TestTask.create block doesn't do what's intended, because the block is being instance_evaled in the context of the TestTask. As a result, t.test_prelude is always blank, breaking test_prelude functionality completely.

This PR uses a temporary variable outside the block to pass this value into the block:

+        test_prelude = self.test_prelude
         Minitest::TestTask.create :test do |t|
-          t.test_prelude = self.test_prelude
+          t.test_prelude = test_prelude
           t.libs += Hoe.include_dirs.uniq
         end

2. In lib/minitest/test_task.rb the order of the framework snippet and the prelude snippet are reversed as compared to the pre-v3.18.0 implementation.

Where previously this code put the prelude in front of the framework snippet:

    tests = ["rubygems"]
    tests << framework if framework
    tests << test_globs.sort.map { |g| Dir.glob(g) }
    tests.flatten!
    tests.map! { |f| %(require "#{f}") }

    tests.insert 1, test_prelude if test_prelude

The current code reverses this sense:

       runner = []
       runner << framework
       runner << test_prelude if test_prelude
       runner.concat tests
       runner = runner.join "; "

This PR restores the original order, which as it turns out is critical to getting SimpleCov to work with Minitest. (See sparklemotion/nokogiri#1965 for the SimpleCov-related problem that spawned this particular yak shave!)

[flavorjones]

@zenspider just a gentle ping on this - let me know if you'd like a different approach taken to address my issues. thanks for all your work.

[zenspider]

Just saw your ping... I'm poking. I think your approach is fine, but your tests all pass w/o any patch to lib so they won't prevent a regression.

[zenspider]

AH. OK... I figure out what's going on. The tests are always going against the old make_test_cmd even when sometimes it is set up to go against the new TestTask which has its own (broken) make_test_cmd.... lemme try to modify the tests to expose.

[zenspider]

Please verify:

  # here just for comparison:
  EXPECTED = %W[-w -Ilib:bin:test:.
                -e 'require "rubygems"; %srequire "test/test_hoe_test.rb"'
                --].join(" ") + " "

  MT_EXPECTED = %W[-Ilib:test:. -w
                   -e '%srequire "test/test_hoe_test.rb"'
                   --].join(" ") + " "

  require "minitest/test_task" # currently in hoe, but will move

  def test_make_test_cmd_for_minitest
    skip "Using TESTOPTS... skipping" if ENV["TESTOPTS"]

    framework = %(require "minitest/autorun"; )

    @tester = Minitest::TestTask.create :test do |t|
      t.libs += Hoe.include_dirs.uniq
      t.test_globs = ["test/test_hoe_test.rb"]
    end

    assert_equal MT_EXPECTED % [framework].join("; "), @tester.make_test_cmd
  end

  def test_make_test_cmd_for_minitest_prelude
    skip "Using TESTOPTS... skipping" if ENV["TESTOPTS"]

    prelude = %(require "other/file")
    framework = %(require "minitest/autorun"; )

    @tester = Minitest::TestTask.create :test do |t|
      t.test_prelude = prelude
      t.libs += Hoe.include_dirs.uniq
      t.test_globs = ["test/test_hoe_test.rb"]
    end

    assert_equal MT_EXPECTED % [prelude, framework].join("; "), @tester.make_test_cmd
  end

[flavorjones]

The tests you put inline above look good to me, and reflect the expected behavior. Thanks!

[flavorjones]

Would you like me to resubmit this PR with your suggested test structure?

[zenspider]

I already got ya (9b07634).

I should have closed this. I'll ship nowish.

[flavorjones]

Thank you!