Fixed RDOC dependency for 5.0.0 #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenspider
requested changes
Feb 1, 2017
| @@ -100,7 +100,7 @@ def initialize_publish | |||
| # Declare a dependency on rdoc, IF NEEDED. | |||
|
|
|||
| def activate_publish_deps | |||
| dependency "rdoc", "~> 4.0", :developer if need_rdoc | |||
| dependency "rdoc", ">= 4.0", :developer if need_rdoc | |||
There was a problem hiding this comment.
No unbounded deps please.
http://www.zenspider.com/ruby/2008/10/rubygems-how-to-preventing-catastrophe.html
There was a problem hiding this comment.
How would you handle this scenario then where you need to work with rdoc ~> 4.0 and rdoc ~> 5.0?
There was a problem hiding this comment.
Sorry... Um... probably >= 4.0 and < 6...
There was a problem hiding this comment.
I guess that is basically the same isn't it? When will RDOC get a major 6 version?
|
I've made a corresponding change. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix a dependency issue with RDoc 5.0.0.
rake newbwas broken.With this fix everything works again.