Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec.encode original volume maybe delete fail #4642

Closed
Numblgw opened this issue Jul 5, 2023 · 1 comment
Closed

ec.encode original volume maybe delete fail #4642

Numblgw opened this issue Jul 5, 2023 · 1 comment

Comments

@Numblgw
Copy link
Contributor

Numblgw commented Jul 5, 2023

Describe the bug
ec.encode command maybe fail when execute delete original volume step
command:

weed shell -master=xxxx
lock
ec.encode -collection=xxxx -volumeId=xxxx
unlock

log output:

markVolumeReadonly 154 on 10.117.32.36:9334 ...
markVolumeReadonly 154 on 10.117.32.34:9334 ...
markVolumeReadonly 154 on 10.117.32.35:9334 ...
........
........
delete volume 154 from 10.117.32.36:9334
delete volume 154 from 10.117.32.35:9334
delete volume 154 from 10.117.32.35:9334

10.117.32.35 delete execute repeated, 10.117.32.34 not delete

System Setup
any cluster with more than 2 replica, for example: -defaultReplication=020

Screenshots
image

Additional context
i think this caused by the shared memory of the locations slice.While iterating through the locations and deleting the original volume, the master client will also update the members in the locations.

reproduce: add a sleep within the loop. file: weed/shell/command_ec_encode.go, line: 185
image

@chrislusf
Copy link
Collaborator

thanks for the detailed report and insights!

kmlebedev pushed a commit to kmlebedev/seaweedfs that referenced this issue Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants