Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab design (update) #66

Open
4 of 7 tasks
ulde01 opened this issue Aug 26, 2019 · 3 comments
Open
4 of 7 tasks

Tab design (update) #66

ulde01 opened this issue Aug 26, 2019 · 3 comments

Comments

@ulde01
Copy link
Contributor

ulde01 commented Aug 26, 2019

Design update 2019-10-25

image

The design of the tab component has been adjusted:

  • States for hover and focused have been updated
  • Overflow tab is left-aligned (used to be right-aligned)

Mobile version

  • The arrow is moved into the tab and a tiny line is added to look like a tab
  • Instruction is clarified: Feel free to display more than one tab in a mobile. If there are too many tabs for the width that calls for an overflow menu, then only the active tab is presented (with arrow).

See the specification to get the correct details:
https://designlibrary.sebgroup.com/components/tab/#specification

Original discussion
#66

Thank you @TheresaHedlund for working on this!

Follow-up on development:

Original issue

Bootstrap-sync, July 2019

The examples in DL makes it look like many examples are for mobile, change content in the tabs. Make sure the examples are varied in width so readers understand that the width is flexible according to content. Clarify how it should work in mobile.

  • Add new examples to DL
  • update symbols
  • double check hover-effects, should be blue like buttons
@ulde01
Copy link
Contributor Author

ulde01 commented Sep 9, 2019

To clarify Design library image description: @TheresaHedlund

  • Remove second desc in image
  • Move in overflow to normal
  • Change mobile to one tab with overflow

@TheresaHedlund
Copy link

To clarify Design library image description: @TheresaHedlund

  • Remove second desc in image
  • Move in overflow to normal
  • Change mobile to one tab with overflow

I have added a Tabs file in SEB Components_ALL in Abstract:
https://share.goabstract.com/39e93242-724e-4f4c-b0b7-faa983b82a37?sha=8e4c4b9df29e2fb19f8b0399cb8e189701b76783
My suggestion is to keep the possibility to have at least 2 tabs also for mobile, when there's enough space.
What do you think @JessiNygrenWalhed @conandx @ulde01?
Have not removed the old Tabs page from the mixed file yet.

@ulde01
Copy link
Contributor Author

ulde01 commented Oct 25, 2019

Design update 2019-10-25

The design of the tab component has been adjusted:

  • States for hover and focused have been updated
  • Overflow tab is left-aligned (used to be right-aligned)

Mobile version

  • The arrow is moved into the tab and a tiny line is added to look like a tab
  • Instruction is clarified: Feel free to display more than one tab in a mobile. If there are too many tabs for the width that calls for an overflow menu, then only the active tab is presented (with arrow).

See the specification to get the correct details:
https://designlibrary.sebgroup.com/components/tab/#specification

Thank you @TheresaHedlund for working on this!

Any feedback? Do contact designlibrary@seb.se
Ulrika,
Design Management

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants