-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question #2
Comments
Hello, This might indeed need some clarification in the readme. The only adverse affect of the file change is that you can not publish to atmosphere with the file change. It disables login to the package server, which atmosphere requires but stratosphere currently does not support. You can however always undo the file change and everything is back to normal. |
Interesting,
I'd be interested in possibly doing a PR if you can point me in the right direction. |
Well, Meteor-tool tries to do an oAuth login with a meteor developer account. So in theory, setting up oAuth for meteor developer accounts (using default package: meteor-developer-accounts) should be sufficient. But this gave me errors. |
@sebakerckhof I agree that this app is sorely needed. I am also interested in hosting my own packages. Maybe we can figure out the OAuth issue together :-) I cloned the repo, created my OAuth app on meteor.com, and went to start it. But it's not clear what needs to be done in step 5. I found my packages database file. But when I look in the app, there are no instructions. Help? |
Have you tried typing meteor login prior to publishing the package. ?
|
Not yet. I thought that before I started publishing my own packages, I would see all the Atmosphere packages on my Stratosphere app. Right now, the main screen says 'No published packages', since I haven't done the syncing step and the directions aren't clear. More info: I went ahead and created a toy Meteor app with
|
Note that, although the database will contain all packages (your own + from atmosphere) the GUI will only show private packages. Mainly because the GUI is written pretty fast and not ready to handle huge amounts of data (no good search, no good paging, ...). + Atmosphere does a pretty good job for public packages. |
@hellogerard the issue could have 2 causes.
Basically if you have your packages.data.db you should copy it and rename it to a sanitized version of your package server url, in your case this would be: localhostX9000.data.db. Normally this should be visible in the instructions in the frontend somewhere. But I rewrote the frontend for beta1 (it used to be based on Telescope) and I might have missed this part. This copying is also something I hope we can avoid in the future, therefore I opened this issue: meteor/meteor#5391 |
Feel free to assign something to me if you'd like help |
@sebakerckhof That last commit fixed the error. Thanks! Interestingly, after that was fixed, I didn't need to copy the database file. I just started Stratosphere, and started my app with the environment variable, and everything seems to be working. I can start the app, run I tried publishing my first private package and got stopped. I will create a new issue for that. |
Yeah, copying of the database is not always necessary. It depends on what command you execute, so the step is there to make sure it always works. However, once it has synchronized, you're good to go for every meteor-tool command. |
@rwatts3 All help is welcome. However for some things you'll need a good understanding of how meteor deals with packages and the structure of the package database. This isn't documented somewhere, I'll try to do this once I've got some time. The easiest thing to help with would be improvements to the frontend (based on angular-material), but this is also the least important for now. The most annoying thing is the oAuth flow, since it means there is no login to the package server and the file modifications are necessary. Maybe you can help there. I'll make a new branch where I'm going to enable meteor-developer-accounts and then maybe we'll find what goes wrong. |
Sounds good, So from what I understand the goal is to allow the oAuth to function without modifying the meteor-tools file. |
Exactly. I've tried this before but I ran into errors described here: meteor/meteor#4497 Thing is that there are 3 parties involved (meteor-tool, stratosphere and meteor.com servers) and all communication is asynchronous, which makes it very hard to debug. |
@sebakerckhof Thanks for the clarification.
and
These remarks might make good additions to the README. (I know, I know, pull request) |
@rwatts3 This branch has meteor-developer-accounts enabled and a minimal front-end to test manual login https://github.com/sebakerckhof/stratosphere/tree/oauth That should be enough to get you started (of course, You'll have to undo the changes to auth-client.js ). @hellogerard Yeah, the readme can use a lot of improvements, but I'd rather focus on trying to make sure some steps are not necessary anymore. |
@rwatts3 Actually, I just found out that I can login with meteor-tool 1.1.9 and the oauth branch. Can you verify? You will however need to set the redirect url in your meteor app to: and make sure the settings in settings.json are correct. |
Everything is working for me now 👍 |
Yeah I verified the same thing. So there is no need to change the file
|
Ok so i'm having trouble setting the environment variable . Meteor still publishes to atmosphere. |
That's... very strange. Really almost impossible if you see how simple the code is: https://github.com/meteor/meteor/blob/devel/tools/meteor-services/config.js#L139 Could you maybe do a console log there of your environment variables. Are you sure you've set them permanently on your system and not just temporarily (what the commands in the readme will do)? |
I'll try to set it again. I'm using windows right now mac is at home but it didn't quite work that well last time It published 2 packages to the atmosphere |
Actually , |
Ok , I think we should consider writing scripts to handle the editing of the environment variables and the db for the user. This will make it a more seamless project. |
I usually prepend the environment variable on the command line, like this: $ METEOR_PACKAGE_SERVER_URL=http://localhost:3000 meteor
$ METEOR_PACKAGE_SERVER_URL=http://localhost:3000 meteor add my:package
$ METEOR_PACKAGE_SERVER_URL=http://localhost:3000 meteor list |
I've got them saved in my bash profile on linux and using the gui editor on I'm currently finishing a (quick and dirty) user management in the GUI and 2015-10-16 21:13 GMT+02:00 Gerard Sychay notifications@github.com:
|
The oauth branch is gone ? I've got everything setup however I can't seem to login upon creating a new package. |
The branch is merged into master. |
Receiving this error when trying to publish Error: access-denied
at sendAuthorizeRequest (C:\tools\meteor-services\auth.js:351:11)
at oauthFlow (C:\tools\meteor-services\auth.js:382:25)
at Object.exports.loginWithTokenOrOAuth (C:\tools\meteor-services\auth.js:956:17)
at Object.exports.loggedInConnection (C:\tools\meteor-services\auth-client.js:87:12)
at Object.exports.loggedInPackagesConnection (C:\tools\packaging\package-client.js:232:21)
at Command.main.registerCommand.name [as func] (C:\tools\cli\commands-packages.js:305:32)
at C:\tools\cli\main.js:1378:23 |
I just released beta 2 which has a lot of changes regarding user authentication and management. Note that the settings.json file template has changed (allowedUsers is renamed to superUsers). Some remarks: -If loginRequired is set to true, you need to add at least one superUser (meteor developer account name). Super users can add and manage other users in a new part of the GUI. |
Thank you I will pull the latest update down now and give it a spin |
By the way I got it working. |
Hello,
First thank you for building this project. I am curious is this simply a packaging system similar to Atmosphere, where I deploy stratosphere on my server, then I can make pull my own packages?
Also is this approach dual compatible meaning can I use Atmospherejs packages as well as my own private packages ?
And finally I am using meteor 1.2.0.2 , and meteor tool s at 1.1.9, will this have any adverse affects by modifying that file with the changes in your instructions?
The text was updated successfully, but these errors were encountered: