Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #10 for MAC users #12

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

gapp-c
Copy link
Contributor

@gapp-c gapp-c commented Sep 27, 2023

fixes issue #10

@sebastian-zieba
Copy link
Owner

Hi Cyril, Thanks for the PR! I'll have a look at it, run the workflow, and merge it to master.

@sebastian-zieba sebastian-zieba self-assigned this Sep 27, 2023
@sebastian-zieba sebastian-zieba added the bug Something isn't working label Sep 27, 2023
@sebastian-zieba sebastian-zieba linked an issue Sep 27, 2023 that may be closed by this pull request
@sebastian-zieba
Copy link
Owner

Looks good to me! That would definitely fix that issue. Thanks!

I think MAC users would also appreciate it if PACMAN would ignore .DS_Store files altogether.
Could you add the following two lines to the end of the ".gitignore" file? That would ignore these files in the future when someone does for example "git status".

Just commit and push these changes and I'll approve it :)

# Mac/OSX
.DS_Store

@gapp-c
Copy link
Contributor Author

gapp-c commented Sep 27, 2023

Sure thing! :-)

Copy link
Owner

@sebastian-zieba sebastian-zieba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4b5384c) 69.95% compared to head (97af993) 70.02%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   69.95%   70.02%   +0.07%     
==========================================
  Files          56       56              
  Lines        4832     4834       +2     
==========================================
+ Hits         3380     3385       +5     
+ Misses       1452     1449       -3     
Files Coverage Δ
src/pacman/lib/util.py 77.63% <100.00%> (+0.04%) ⬆️
src/pacman/s21_bin_spectroscopic_lc.py 94.18% <100.00%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastian-zieba
Copy link
Owner

All tests ran successfully. I'm merging this PR.

@sebastian-zieba sebastian-zieba merged commit b1a07b3 into sebastian-zieba:master Sep 27, 2023
8 checks passed
@MBSck MBSck mentioned this pull request Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with "no directory" when running s21
3 participants