-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue #10 for MAC users #12
Conversation
Hi Cyril, Thanks for the PR! I'll have a look at it, run the workflow, and merge it to master. |
Looks good to me! That would definitely fix that issue. Thanks! I think MAC users would also appreciate it if PACMAN would ignore .DS_Store files altogether. Just commit and push these changes and I'll approve it :)
|
Sure thing! :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #12 +/- ##
==========================================
+ Coverage 69.95% 70.02% +0.07%
==========================================
Files 56 56
Lines 4832 4834 +2
==========================================
+ Hits 3380 3385 +5
+ Misses 1452 1449 -3
☔ View full report in Codecov by Sentry. |
All tests ran successfully. I'm merging this PR. |
fixes issue #10