-
-
Notifications
You must be signed in to change notification settings - Fork 86
Clean up the test suit #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up the test suit #73
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
=============================================
- Coverage 99.74% 62.43% -37.32%
Complexity 150 150
=============================================
Files 10 10
Lines 397 386 -11
=============================================
- Hits 396 241 -155
- Misses 1 145 +144
Continue to review full report at Codecov.
|
all done (I think) not sure what is going on with the coverage report, no tests have been removed |
Please keep test case classes in the same namespace as the class they're testing. |
updated |
Thanks for your quick responses. Is this ready to be merged? |
Squashed to get a clean commit for the changes, if the tests are green it should be good. |
Don't worry about the |
👍 thanks :) |
Sadly, after the release of v2 not all are happy with it.
I'm sorry and hereby apologize to everyone who is effected by the changes.
The intent for v2 was to provide an extendable
diff
library together with some issue resolving which required BC breaks.However some changes were not up to par and need work.
This PR is the start of resolving the reported issue.
First of I want to create a nice and clean test suite for the package such that new changes can be reviewed more easy.
The changes are:
DifferTest
to dedicated test per classTo be clear, besides the namespace change of the Exceptions, there are no functional changes to the package in this PR (only to its tests).
Ping @keradus if you've time please do a sanity check :)