Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Backport v5 performance improvements onto v4.0.4 (3461e3f) #120

Conversation

DannyvdSluijs
Copy link

This is a backport of the performance improvements (#118/#119) suggested by @staabm. And supported by the repository maintainer in #118 (comment)

⚠️ This is still pointing to the main branch as there is no 4.x branch. @sebastianbergmann could you create such a branch so I can point the PR to the right target branch?

Secondly I'm also seeing 40k installs per day for the v3 releases. Does this amount also validate the backport into v3?

@sebastianbergmann
Copy link
Owner

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.

I backported 792812d and b0a1aad to 3.0 and tagged 3.0.4.

I recreated 4.0 based on 4.0.4, backported 792812d and b0a1aad to 4.0 and tagged 4.0.5.

@DannyvdSluijs DannyvdSluijs deleted the performance-backports branch May 7, 2023 07:45
@DannyvdSluijs
Copy link
Author

No worries was only trying to help out to make sure both v3 and v4 got updated as well.

Thanks you for your efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants