-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to set contextLines in __construct() on UnifiedDiffOutputBuilder #122
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
=========================================
Coverage 99.32% 99.32%
Complexity 220 220
=========================================
Files 12 12
Lines 589 590 +1
=========================================
+ Hits 585 586 +1
Misses 4 4 ☔ View full report in Codecov by Sentry. |
I fixed psalm notice by add |
Hi and thanks for the PR! May I ask why you do not use the |
we use it directly on rector, see It require private accessor to change that. |
I think maybe changing the output builder from |
Just slightly looking at that, the logic seems different, so I want to avoid bc break, I think adding more params will be ok on this class, as it will allow get non-strict usage of diff, while got functonality to set the |
Check, I see your point. Yet, end of day I think rector would be a better tool by offering udiff format compliant output to its users over the loose format it does now. I can see why you're creating this PR because of BC reasons, although I'm not in favor of it. Than again, it is not up to me :) |
No description provided.