Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied Extract refactoring method to Differ.php #35

Merged
merged 6 commits into from
May 13, 2017

Conversation

IcyApril
Copy link

The Differ.php file clearly contains some very long methods, I have broken these down using the Extract refactoring method such that functions are now easier to read. Hoping to do more refatoring in this class, but this is a start.

@IcyApril
Copy link
Author

IcyApril commented Jul 24, 2016

@sebastianbergmann FYI, all the tests run successfully, the only reason for the failure of 5.3.3 on Travis (whilst it works completely fine with 5.3) is the fact that the Travis PHP 5.3.3 doesn't have the openssl extension installed and therefore it can't install composer.

@sebastianbergmann sebastianbergmann merged commit 2d1114d into sebastianbergmann:master May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants