Differ constructor: fix @param annotation types #76
Conversation
| @@ -25,7 +25,7 @@ | |||
| private $outputBuilder; | |||
|
|
|||
| /** | |||
| * @param DiffOutputBuilderInterface $outputBuilder | |||
| * @param string|null|DiffOutputBuilderInterface $outputBuilder | |||
There was a problem hiding this comment.
You shouldn't pass string|null that is just for BC/legacy support because a release was done early, as such I left the hint out as to trigger SCA warnings for people so they start updating.
There was a problem hiding this comment.
LoL, I just opened this because of https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/2.2/src/Differ/SebastianBergmannShortDiffer.php#L29 :P
There was a problem hiding this comment.
^_^ that class will be removed in PHP-CS-Fixer 3.0 so we should be good ;)
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
=========================================
Coverage 99.48% 99.48%
Complexity 150 150
=========================================
Files 10 10
Lines 386 386
=========================================
Hits 384 384
Misses 2 2
Continue to review full report at Codecov.
|
No description provided.