PHPUnit_Util_XML::cssSelect() does not populate $isHtml correctly

[tobyS]

Due to this, assertion of XML is impossible using PHPUnit_Framework_Assert::assertSelect*().

Here is a patch:

diff --git a/PHPUnit/Util/XML.php b/PHPUnit/Util/XML.php
index 3e73b76..d369fba 100644
--- a/PHPUnit/Util/XML.php
+++ b/PHPUnit/Util/XML.php
@@ -522,12 +522,13 @@ class PHPUnit_Util_XML
      * @since  Method available since Release 3.3.0
      * @author Mike Naberezny <mike@maintainable.com>
      * @author Derek DeVries <derek@maintainable.com>
+     * @author Tobias Schlitt <toby@php.net>
      */
     public static function cssSelect($selector, $content, $actual, $isHtml = TRUE)
     {
         $matcher = self::convertSelectToTag($selector, $content);
         $dom     = self::load($actual, $isHtml);
-        $tags    = self::findNodes($dom, $matcher);
+        $tags    = self::findNodes($dom, $matcher, $isHtml);

         return $tags;
     }

[sebastianbergmann]

Hello Tobias,

please fork PHPUnit, apply the patch, and then send me a pull request.

Thanks!
Sebastian

[sebastianbergmann]

Closed by 95255f0 and #21.