Regex filtering

[johncrenshaw]

The current mechanisms for filtering large numbers of files from coverage data are horribly inadequate, especially for projects that use large monolithic libraries like Zend Framework.

I've made a few changes to PHPUnit_Util_Filter to allow regex based filters. (Blacklist only, since whitelists would be difficult to properly support, and wouldn't be made any faster by this, although a regular expression parameter on the whitelist might make sense.)

I didn't rewrite addDirectoryToFilter, so it's still slow, but this gives a workaround for now, and it shouldn't be too hard to rewrite addDirectoryToFilter later. (realpath, explode, preg_quote all segments with $delimiter='', implode with $glue='(\|/)'), and wrap with ''.)

This patch also allows for other useful exclusions, such as:
PHPUnit_Util_Filter::addRegexToFilter('test(s?)', 'TESTS');

[ped7g]

I have been struggling with speed of addDirectoryToFilter / addFileToFilter too when running ordinary non code coverage tests.
(I can live with the penalty when running code coverage, as it takes 2 times longer then normally anyway, so additional 2 secs doesn't matter at all at that point)

For now I have a workaround by doing this in test bootstrap.php:
define('PHPUNIT_COVERAGE', '--coverage');
foreach( $GLOBALS['argv'] as $opt ) {
if ( strncasecmp( $opt, PHPUNIT_COVERAGE, strlen(PHPUNIT_COVERAGE) ) == 0 ) {
//calls to addDirectoryToBlacklist(...) are here
}
}

But when I tried to profile the ordinary test, I figured out the PHPUnit does blacklist itself no matter if the code coverage is set on or off, which costs me additional ~1sec of tests execution.

Your solution would solve both cases by simply making the blacklisting cheap enough to be used all the time.
+1 for your patch

[johncrenshaw]

lol, if the delay had only been 2 seconds that would have been fine. I was excluding the entire Zend Framework, which is more like a 30 second delay. The patch is also useful for excluding things like '.test.' which otherwise cannot be excluded.

[sebastianbergmann]

Closing, as the code this pull request is for is not part of PHPUnit anymore.