Enable matching array keys against constraints

[andreaswolf]

Array keys may now be matched against all string (starts/ends with, contains, PCRE) and numeric matchers (is null, greater than, less than).

This introduces two new interfaces (StringConstraint and NumericConstraint), which could be replaced with one interface ArrayKeyConstraint if that is more feasible.

[sebastianbergmann]

Please use the instanceof operator instead of is_object() and is_a().

[andreaswolf]

Fixed the issues you mentioned, Sebastian.

[andreaswolf]

And just stumbled across this... IsNull is not a numeric constraint IMHO, so I reverted that change.

[cweiske]

Any news on this? I'd like to see that feature, too.

[damncabbage]

Any news on this? I'd like to see this feature as well.

[craigmarvelley]

👍 This would be a really handy feature.

[catchamonkey]

👍

[damncabbage]

RSpec::Mocks has had hash_including since 2008. Please consider merging this pull request so we can try catching up a little bit.

[whatthejeff]

@damncabbage, This PR does not add the equivalent of hash_including (see: argument_matchers.rb). This PR adds support for matching an array key against some of the existing PHPUnit constraints. For instance:

$array = array(
  9       => 'foobar',
  'name6' => 'Jeff'
);

$this->assertArrayHasKey(
  new PHPUnit_Framework_Constraint_PCREMatch('/name\d/'),
  $array
);

$this->assertArrayHasKey(
  new PHPUnit_Framework_Constraint_StringStartsWith('name'),
  $array
);

$this->assertArrayHasKey(
  new PHPUnit_Framework_Constraint_StringEndsWith('6'),
  $array
);

$this->assertArrayHasKey(
  new PHPUnit_Framework_Constraint_StringContains('ame'),
  $array
);

$this->assertArrayHasKey(
  new PHPUnit_Framework_Constraint_GreaterThan(8),
  $array
);

$this->assertArrayHasKey(
  new PHPUnit_Framework_Constraint_LessThan(10),
  $array
);

[whatthejeff]

Would someone be willing to provide some use cases for this?

[wildlyinaccurate]

What does this PR need in order to be merged?

@whatthejeff use cases are something like parsing a string and expecting an array which contains certain keys. This would be more elegant and meaningful than the current way which would be:

$this->assertTrue(array_key_exists('key', $array));

Edit: Ha, ignore me. I just saw that assertArrayHasKey() exists!

[sebastianbergmann]

What this pull request needs is use cases.

[whatthejeff]

I think it's time to close this for a couple of reasons:

1. This PR is very old and can no longer be automatically merged.
2. No one has provided uses cases since we asked for them 3 months ago.