Exclude directories - Use AbsolutePath

[mgb]

When you run phpunit using a configuration file where the current working directory does not match the configuration's directory, phpunit will fail to exclude paths in testsuites correctly.

Sample configuration:

  <testsuite name="Normal Test Suite">
    <directory>.</directory>
    <exclude>LongTests</exclude>
    <exclude>FlakyTests</exclude>
  </testsuite>

If you run that configuration from any other directory, the . will go to the absolute path of the configuration, while the excludes will only exclude from your current working directory (which won't match the . directory).

[estahn]

+1 Have this issue as well.

[edorian]

We might very well do this for 3.8. The question that we have to consider is how big the BC impact will be and if it would make sense to have it check relative and then absolute.

Just to state why this isn't a easy merge :)

[blaiz]

+1

[jschlies]

+1

[whatthejeff]

I've discussed this with @sebastianbergmann and he is okay with the BC break. Expect this to be merged in the next couple of days.

[whatthejeff]

@mgb, 9740a58 should fix your issue. I decided not to merge this PR in favor of a slightly more efficient solution. At any rate, thanks for your help in resolving this issue :)

[ghost]

So this is not merged? I still have the problem on PHPUnit 3.7.28. What is the solution besides using absolute paths? Also if I specify a directory path and a configuration path, the configuration is ignored.

[srlucas]

I am experiencing the same issue.

using absolut paths will cause some issues with CI environments.

[whatthejeff]

@daniphp @srlucas this fix lands in the 4.0 release as it breaks backwards compatibility.