Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assigning to Nullable Enum #715

Merged
merged 3 commits into from
Mar 19, 2020
Merged

Fix assigning to Nullable Enum #715

merged 3 commits into from
Mar 19, 2020

Conversation

KurtGokhan
Copy link
Contributor

Summary:

  • added test for nullable enum and struct assignment
  • fix nullable enum assignment
  • microoptimizations in DefaultTypeConverter (I am not sure about its benefits)

Also #153 and #157 are not reproducible anymore.

@sebastienros
Copy link
Owner

I think typeof expression are resolved at compile time. Also private member should be prefixed with _, or in upper case for constants. Merging as these are minor.

@sebastienros sebastienros merged commit bf3cc21 into sebastienros:dev Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants