Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize property iteration for ObjectWrapper #750

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Harmonize property iteration for ObjectWrapper #750

merged 1 commit into from
Jun 22, 2020

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Jun 22, 2020 •
edited
Loading

  • refactored earlier PR's property traversal as helper method
  • now using same property iteration for getOwnProperteis and getOwnPropertyKeys
  • fixed possible issue of listing properties twice if they have been accessed via indexer before
  • JSON.stringify now produces expected result

fixes #298
fixes #164

@lahma lahma mentioned this pull request Jun 22, 2020
Closed
@lahma lahma merged commit 5bd7f46 into sebastienros:dev Jun 22, 2020
@lahma lahma deleted the json-stringify-clr-objects branch June 22, 2020 19:50
@lahma lahma mentioned this pull request Jun 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienros sebastienros sebastienros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Javascript objects defined from .NET dictionary CLR objects not enumerable
2 participants
@lahma @sebastienros