Gracefully handle recursive engine invocations #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
force-pushed
the
bugs/recursive-call-stack
branch
2 times, most recently
from
8ef9830
to
e2404d8
Compare
lahma
force-pushed
the
bugs/recursive-call-stack
branch
from
e2404d8
to
23f121a
Compare
sebastienros
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recursive calls were not working when stack recording is active. Before this was not an issue when the test case was running without recursion limits and thus the stack collection was off. Now it's always on and surfaced the problem. Now only resetting state if we know that engine has exited cleanly from earlier call.
fixes #835