Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for remote to be a private ip #9

Open
mmlb opened this issue Mar 4, 2019 · 1 comment
Open

Allow for remote to be a private ip #9

mmlb opened this issue Mar 4, 2019 · 1 comment

Comments

@mmlb
Copy link

mmlb commented Mar 4, 2019

IsPublicIP is called from Parse, this applies even if we've configured AllowedSubnets. I'd still argue IsPublicIP does not belong as a filter by default since there's no reason why a proxy must be globally addressable (think entirely private services), but that could be a dangerous change to make at this point.

I'd be happy to come up with a PR for this, is there some form you'd like to see this implemented?

@SpoonOne
Copy link

We have a staging environment which is on private addressing and this affects us as well. We would like to be able to have the remote IP be a private IP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants