Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include templates in sdist (source distribution) #3

Merged
merged 1 commit into from
Mar 18, 2019

Conversation

adamyi
Copy link
Contributor

@adamyi adamyi commented Mar 18, 2019

See discussion at pypa/sampleproject#30 (comment)

(Otherwise, python3 setup.py install will install a bdist which includes templates, yet pip3 install flask-core/ will install an sdist which doesn't include templates)

to include templates in sdist
@cry
Copy link
Contributor

cry commented Mar 18, 2019

You're referring to the templates inside flask_core/templates/ right? Our deployment procedure installs this repository from refs/master like so -e git+https://github.com/secedu/flask-core.git@master#egg=flask-core, which does give us all the required templates. Please test if installing the package like that resolves your template problem.

Either way, adding a MANIFEST.in can't hurt so I'll merge this in.

@cry cry merged commit cb5cd18 into secedu:master Mar 18, 2019
cry pushed a commit that referenced this pull request Mar 18, 2019
Includes templates in sdists & bdists.
cry added a commit that referenced this pull request Mar 19, 2019
* Commit progress

* Finish up db isolation

* Add some documentation on how to isolate.

* Add more pydoc

* Remove testing session

* Don't attempt to isolate if not enabled

* Add MANIFEST.in (#3)

Includes templates in sdists & bdists.

* Add bumpversion for versioning

* Don't attempt to isolate if not enabled

* Return none on no cookies sent

* Clarify why no cookies fails auth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants