Generate release notes from tag release to the built tag.
#895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also try to cross-reference release page and build page.
Using github.ref as action-gh-release's target_commitish produces:⚠️ GitHub release failed with status: 422 [{"resource":"Release","code":"invalid","field":"target_commitish"}]
This should (!) allow us to generate full release notes relative to the previous viewer release, instead of letting action-gh-release guess incorrectly. Also try again to add to the release page a back-link to the specific build.
instead of on the current tag 7.1.2-release.
|
Note that the build page has a link to the release page, and vice-versa. (Scroll down on the release page.) This PR did not yet exist at the time of that tag build, which is why the |
marchcat
approved these changes
Feb 26, 2024
|
I'll be interested to see the next tag build. |
|
I'll likely build one tonight. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly specify both
target_commitishandprevious_taginputs to the GitHub release-notes generator. Unless they're both explicitly passed, action-gh-release guesses wrong about the range of commits to consider for release notes generation.This change uses the new action-gh-release feature
previous_tag(secondlife-3p/action-gh-release#2). Once that PR is merged, we can revert to referencingsecondlife-3p/action-gh-release@v1.This behavior also depends on maintaining a new viewer tag
releaseto track the most recent release, updating it every time we promote a new default download viewer.Also add cross-links between the build page and the corresponding release page.
relnotes:
This text should be copied to the release page.
It should include everything after the
relnotes:line.