Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonld jinja transformation #15

Merged
merged 17 commits into from
Jul 26, 2024
Merged

Jsonld jinja transformation #15

merged 17 commits into from
Jul 26, 2024

Conversation

argenos
Copy link
Member

@argenos argenos commented Jul 18, 2024

Closes #10

@argenos argenos linked an issue Jul 18, 2024 that may be closed by this pull request
@Samuel-Wiest Samuel-Wiest marked this pull request as ready for review July 19, 2024 07:18
Copy link
Contributor

@Samuel-Wiest Samuel-Wiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine for me. When I checkout the branch and run it on a .floorplan file, the json files are generated without any errors.

@argenos argenos force-pushed the jsonld-jinja-transformation branch from ad654df to 9f0686d Compare July 23, 2024 06:59
Copy link
Contributor

@Samuel-Wiest Samuel-Wiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this error when I run it, could we discuss it 22.07.24?
(.venv) sam@Work-Legion:~/secorolab/Floorplan-DSL/src$ blender --background --python exsce_floorplan/exsce_floorplan.py --python-use-system-env -- ../models/examples/hospital.floorplan
Color management: using fallback mode for management
Color management: Error could not find role data role.
Blender 3.0.1
Read prefs: /home/sam/.config/blender/3.0/config/userpref.blend
Color management: scene view "Filmic" not found, setting default "Standard".
../output/hospital/mesh
ERROR (bke.modifier): ./source/blender/blenkernel/intern/modifier.c:457 BKE_modifier_set_error: Object: "reception.wall3", Modifier: "boolean", Compiled without GMP, using fast solver
ERROR (bke.modifier): ./source/blender/blenkernel/intern/modifier.c:457 BKE_modifier_set_error: Object: "reception.wall3", Modifier: "boolean", Compiled without GMP, using fast solver
ERROR (bke.modifier): ./source/blender/blenkernel/intern/modifier.c:457 BKE_modifier_set_error: Object: "hallway.wall2", Modifier: "boolean", Compiled without GMP, using fast solver
ERROR (bke.modifier): ./source/blender/blenkernel/intern/modifier.c:457 BKE_modifier_set_error: Object: "hallway.wall2", Modifier: "boolean", Compiled without GMP, using fast solver
ERROR (bke.modifier): ./source/blender/blenkernel/intern/modifier.c:457 BKE_modifier_set_error: Object: "reception.wall0", Modifier: "boolean", Compiled without GMP, using fast solver
ERROR (bke.modifier): ./source/blender/blenkernel/intern/modifier.c:457 BKE_modifier_set_error: Object: "reception.wall0", Modifier: "boolean", Compiled without GMP, using fast solver
ERROR (bke.modifier): ./source/blender/blenkernel/intern/modifier.c:457 BKE_modifier_set_error: Object: "room_A.wall1", Modifier: "boolean", Compiled without GMP, using fast solver
ERROR (bke.modifier): ./source/blender/blenkernel/intern/modifier.c:457 BKE_modifier_set_error: Object: "room_A.wall1", Modifier: "boolean", Compiled without GMP, using fast solver
ERROR (bke.modifier): ./source/blender/blenkernel/intern/modifier.c:457 BKE_modifier_set_error: Object: "hallway.wall3", Modifier: "boolean", Compiled without GMP, using fast solver
ERROR (bke.modifier): ./source/blender/blenkernel/intern/modifier.c:457 BKE_modifier_set_error: Object: "hallway.wall3", Modifier: "boolean", Compiled without GMP, using fast solver
ERROR (bke.modifier): ./source/blender/blenkernel/intern/modifier.c:457 BKE_modifier_set_error: Object: "room_B.wall0", Modifier: "boolean", Compiled without GMP, using fast solver
ERROR (bke.modifier): ./source/blender/blenkernel/intern/modifier.c:457 BKE_modifier_set_error: Object: "room_B.wall0", Modifier: "boolean", Compiled without GMP, using fast solver
ERROR (bke.modifier): ./source/blender/blenkernel/intern/modifier.c:457 BKE_modifier_set_error: Object: "hallway.wall3", Modifier: "boolean", Compiled without GMP, using fast solver
ERROR (bke.modifier): ./source/blender/blenkernel/intern/modifier.c:457 BKE_modifier_set_error: Object: "hallway.wall3", Modifier: "boolean", Compiled without GMP, using fast solver
ERROR (bke.modifier): ./source/blender/blenkernel/intern/modifier.c:457 BKE_modifier_set_error: Object: "hallway.wall1", Modifier: "boolean", Compiled without GMP, using fast solver
ERROR (bke.modifier): ./source/blender/blenkernel/intern/modifier.c:457 BKE_modifier_set_error: Object: "hallway.wall1", Modifier: "boolean", Compiled without GMP, using fast solver
ERROR (bke.modifier): ./source/blender/blenkernel/intern/modifier.c:457 BKE_modifier_set_error: Object: "hallway.wall1", Modifier: "boolean", Compiled without GMP, using fast solver
ERROR (bke.modifier): ./source/blender/blenkernel/intern/modifier.c:457 BKE_modifier_set_error: Object: "hallway.wall1", Modifier: "boolean", Compiled without GMP, using fast solver

Blender quit

@argenos
Copy link
Member Author

argenos commented Jul 23, 2024

Hmmm that is unlikely to be related, since the PR is not touching the generation using blender, just the JSON-LD models. Can you open an issue and mention which floorplan model you're using?

@Samuel-Wiest Samuel-Wiest merged commit 24792de into main Jul 26, 2024
3 checks passed
@Samuel-Wiest Samuel-Wiest deleted the jsonld-jinja-transformation branch July 26, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Systematically generate JSON-LD representation
2 participants