Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【OSCP】 在 HEU 中实现 DGK 加法同态加密算法 #85

Merged
merged 10 commits into from
Aug 30, 2023
Merged

【OSCP】 在 HEU 中实现 DGK 加法同态加密算法 #85

merged 10 commits into from
Aug 30, 2023

Conversation

zhangwfjh
Copy link
Contributor

@zhangwfjh zhangwfjh commented Aug 10, 2023 •
edited by Candicepan
Loading

Fixed: #77

@usafchn
Copy link
Member

usafchn commented Aug 11, 2023

感谢 @zhangwfjh 的贡献，PR 初步看没有问题，我会在稍后再次 review 此 PR，感谢~ cc @Candicepan

@usafchn usafchn requested a review from Jamie-Cui August 11, 2023 08:49
@Candicepan Candicepan linked an issue Aug 11, 2023 that may be closed by this pull request
在 HEU 中实现 DGK 加法同态加密算法 #77
Closed
@Jamie-Cui Jamie-Cui requested a review from xfap August 15, 2023 05:40
@zhangwfjh zhangwfjh requested a review from usafchn August 17, 2023 05:19
@Jamie-Cui Jamie-Cui removed the request for review from xfap August 17, 2023 07:03
@usafchn usafchn requested a review from xfap August 28, 2023 03:26
usafchn
usafchn reviewed Aug 28, 2023
View reviewed changes
heu/library/algorithms/dgk/key_generator.cc Outdated Show resolved Hide resolved
heu/library/algorithms/dgk/secret_key.cc Outdated Show resolved Hide resolved
heu/library/algorithms/dgk/secret_key.cc Outdated Show resolved Hide resolved
heu/library/algorithms/dgk/secret_key.h Outdated Show resolved Hide resolved
@usafchn usafchn removed the request for review from xfap August 28, 2023 12:51
@usafchn
Copy link
Member

usafchn commented Aug 30, 2023

有个 C++ 代码风格检查没过，还需要用 clang-format 格式化一下

@usafchn
Copy link
Member

usafchn commented Aug 30, 2023

recheck

usafchn
usafchn approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@usafchn usafchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@usafchn usafchn merged commit a6abeea into secretflow:main Aug 30, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2023
@zhangwfjh zhangwfjh deleted the dgk branch October 8, 2023 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Jamie-Cui Jamie-Cui Jamie-Cui left review comments

@usafchn usafchn usafchn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

在 HEU 中实现 DGK 加法同态加密算法
3 participants
@zhangwfjh @usafchn @Jamie-Cui