fix: parsing of the Go version

[ldez]

The parsing of the Go version inside the function GoVersion is based on an incorrect assumption.

gosec/helpers.go

Lines 476 to 482 in 0c8e63e

	func GoVersion() (int, int, int) {
	versionParts := strings.Split(runtime.Version(), ".")
	major, _ := strconv.Atoi(versionParts[0][2:])
	minor, _ := strconv.Atoi(versionParts[1])
	build, _ := strconv.Atoi(versionParts[2])
	return major, minor, build
	}

The Go version follows a specific pattern.

• go1.19rc2
• go1.19beta2
• go1.19.4
• go1.19

The current version of Go is go1.19 then versionParts[2] panic (runtime error: index out of range [2] with length 2)

Fixes #843

The problem has been introduced by #819

Related to golangci/golangci-lint#3071

[ccojocar]

@ldez Please could you fix the lint warnings? Thanks

[ldez]

yes, I will fix that immediately.

[ldez]

in fact, I'm not able to see where is the issue: no information about the file, and locally go fmt doesn't report any issue on helpers.go.

The only problem is the use of //#nosec in main.go: this doesn't follow the official directive syntax: ^[a-z]+:[a-z]+. and it's reported by go fmt

I can fix it, but you have a hidden problem because of the invalid directive syntax.

More information: golangci/golangci-lint#1658

[codecov-commenter]

Codecov Report

Merging #844 (840e586) into master (0c8e63e) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
- Coverage   74.08%   73.92%   -0.17%     
==========================================
  Files          51       51              
  Lines        3180     3187       +7     
==========================================
  Hits         2356     2356              
- Misses        754      761       +7     
  Partials       70       70              

Impacted Files	Coverage Δ
cmd/gosec/main.go	0.00% <0.00%> (ø)
helpers.go	42.76% <0.00%> (-0.97%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ldez]

@ccojocar do you plan to make a bugfix release?
Just to know if I should use a pseudo version or if I should wait for a tagged version.