Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow config to be partially updated #81

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Allow config to be partially updated #81

merged 1 commit into from
Oct 18, 2018

Conversation

RealOrangeOne
Copy link
Contributor

Description

Allow configuration to be partially updated.

Motivation and Context

This allows only some configuration variables to be changed, whilst leaving the defaults in-tact.

Types of changes

Put an x in all boxes that apply

  • Bug fix (non-breaking change which fixes an issue) (kinda)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Put an x in all boxes that apply
If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • I have added/updated docstrings to the code I have touched.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the Changelog to reflect my changes
  • Has the changes been tested against a real Slack instance?

@RealOrangeOne
Copy link
Contributor Author

Test failures don't look related to this PR

Copy link
Owner

@sedders123 sedders123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I agree test failures are not related. Will merge this and deal with CI in another PR.

@sedders123 sedders123 merged commit 065fcf9 into sedders123:develop Oct 18, 2018
@RealOrangeOne RealOrangeOne deleted the partial-config branch October 18, 2018 12:43
sedders123 added a commit that referenced this pull request Nov 5, 2018
sedders123 added a commit that referenced this pull request Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants