Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable building on Linux #2

Merged
merged 7 commits into from
Aug 23, 2023
Merged

Enable building on Linux #2

merged 7 commits into from
Aug 23, 2023

Conversation

Toodles2You
Copy link
Contributor

  • Created a CMake config file
  • Included standard libraries previously only included for Windows
  • Suppressed some compiler warnings

@SmileYzn SmileYzn mentioned this pull request Mar 24, 2023
Closed
@SmileYzn
Copy link

If this is merged i can help to set it the github actions to automate builds

@Toodles2You
Reverted minor logging changes
cae86c0
@Toodles2You
Update CMakeLists.txt
c1273be 
- Remove 32-bit flags for Linux
- Group common source files together
- Include necessary header files
@Toodles2You Toodles2You changed the title Enable building on Linux with CMake & GCC Enable building on Linux Apr 1, 2023
@seedee seedee added the enhancement New feature or request label Aug 23, 2023
@seedee seedee self-assigned this Aug 23, 2023
@seedee seedee merged commit aec4c3c into seedee:master Aug 23, 2023
@seedee
Copy link
Owner

seedee commented Aug 23, 2023

@Toodles2You thanks for all this help g

@goodusername123
Copy link
Contributor

uhhhhh in the "Suppress compiler warnings" commit why was DEFAULT_SMOOTHING2_VALUE changed from -1 to 0? doesn't doing this actively cause maps to look different or worse? https://github.com/seedee/SDHLT/blob/master/src/sdhlt/sdHLRAD/qrad.cpp#L3967C1-L3967C5

@Toodles2You
Copy link
Contributor Author

@goodusername123 Sorry for the late response. That must've been a mistake on my part. I don't remember what my reason was for changing it but, yeah, I probably shouldn't have touched it. Maybe @seedee can revert the default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@seedee seedee

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Toodles2You @SmileYzn @seedee @goodusername123