Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FluentAssembler too strict #67

Closed
pith opened this issue Nov 30, 2015 · 1 comment
Closed

FluentAssembler too strict #67

pith opened this issue Nov 30, 2015 · 1 comment
Assignees
@adrienlauer

Comments

@pith
Copy link
Member

pith commented Nov 30, 2015

The following method:

fluentAssembler.merge(i18nCSVRepresentations).into(Key.class).fromRepository().orFromFactory()

Throw an IllegalStateException (see here) if the some keys are loaded from the repository and some others are created from the factory. This check is maybe a little abusive or it should be possible to skip it.
@adrienlauer
Copy link
Member

I think this check is preventing some interesting use cases to be achieved and will remove it. The goal of fluent assembler is take care of all the plumbing whether an aggregate exists or not.

adrienlauer added a commit to adrienlauer/business that referenced this issue Feb 27, 2017
@adrienlauer
Allow mixed aggregate assembling, fixes seedstack#67
73886a6
adrienlauer added a commit that referenced this issue Feb 27, 2017
@adrienlauer
Merge pull request #84 from adrienlauer/fix-67-mixed-aggregate-assemb…
3954e19 
…ling

Allow mixed aggregate assembling, fixes #67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrienlauer adrienlauer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pith @adrienlauer