Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump TypeScript Eslint #136

Merged
merged 8 commits into from
Mar 24, 2024
Merged

Conversation

samchungy
Copy link
Contributor

@samchungy samchungy commented Mar 12, 2024

Copy link

changeset-bot bot commented Mar 12, 2024

🦋 Changeset detected

Latest commit: 355537b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-config-seek Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@samchungy samchungy changed the title Bump typescript eslint Bump TypeScript Eslint Mar 12, 2024
@samchungy samchungy marked this pull request as ready for review March 12, 2024 05:56
@samchungy samchungy requested a review from a team as a code owner March 12, 2024 05:56
"eslint": ">=7",
"typescript": ">=4.5"
"eslint": ">=8.56.0",
"typescript": ">=4.7.5"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are requirements of Typescript Eslint

.github/renovate.json5 Outdated Show resolved Hide resolved
Copy link
Member

@jahredhope jahredhope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the change. But I'd like to see this change bundled with any other possible breaking changes before releasing. If there are any.

@samchungy
Copy link
Contributor Author

samchungy commented Mar 12, 2024

Happy with the change. But I'd like to see this change bundled with any other possible breaking changes before releasing. If there are any.

Yeah I'll have to chain it up with eslint-config-skuba, skuba breaking changes 😢

"eslint-config-prettier": "^8.8.0",
"eslint-import-resolver-typescript": "3.5.5",
"eslint-plugin-import": "^2.27.5",
"eslint-plugin-jest": "^27.2.3",
"eslint-plugin-jest": "^27.9.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was getting some pnpm warnings about peer dep versions not matching

package.json Show resolved Hide resolved
Co-authored-by: Karl Juri Ots <kjots@kjots.org>
@samchungy samchungy merged commit 217153b into seek-oss:master Mar 24, 2024
4 checks passed
@seek-oss-ci seek-oss-ci mentioned this pull request Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants