Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Find", "Find and replace", and "Jump to line" keyboard shortcuts #343

Merged
merged 37 commits into from
Mar 7, 2024
Merged

Add "Find", "Find and replace", and "Jump to line" keyboard shortcuts #343

merged 37 commits into from
Mar 7, 2024

Commits on Feb 26, 2024

  1. Add find and replace functionality

    @michaeltaranto
    michaeltaranto committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    ee28b06 View commit details
    Browse the repository at this point in the history

  2. Shift code below search bar

    @michaeltaranto
    michaeltaranto committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    a568b6a View commit details
    Browse the repository at this point in the history

  3. Prevent browser shortcuts while search is focused

    @michaeltaranto
    michaeltaranto committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    a75448d View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Add tests

    @michaeltaranto
    michaeltaranto committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    07a4caa View commit details
    Browse the repository at this point in the history

  2. Assert focus before running commands

    @michaeltaranto
    michaeltaranto committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    74b4f5a View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Merge branch 'master' into add-search-replace

    @michaeltaranto
    michaeltaranto committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    7f5d7c3 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Change 'Replace (⌘R)' to 'Find and replace (⌘⌥F)' 

    Update commands in tests
    @felixhabib
    felixhabib committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    65ec147 View commit details
    Browse the repository at this point in the history

  2. Refactor tests

    @michaeltaranto
    michaeltaranto committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    2b79671 View commit details
    Browse the repository at this point in the history

  3. Add waits

    @michaeltaranto
    michaeltaranto committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    b7b0c39 View commit details
    Browse the repository at this point in the history

  4. Type escape differently

    @michaeltaranto
    michaeltaranto committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    90719ad View commit details
    Browse the repository at this point in the history

  5. Whitespace 😘

    @michaeltaranto
    michaeltaranto committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    019a6df View commit details
    Browse the repository at this point in the history

  6. Increase waits

    @michaeltaranto
    michaeltaranto committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    aae4268 View commit details
    Browse the repository at this point in the history

  7. Replace get search field with get dialog and find search field

    @felixhabib
    felixhabib committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    893e393 View commit details
    Browse the repository at this point in the history

  8. Try forcing and retrying 

    This reverts commit 893e393.
    @felixhabib
    felixhabib committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    465b28e View commit details
    Browse the repository at this point in the history

  9. Try without force

    @felixhabib
    felixhabib committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    09d82a5 View commit details
    Browse the repository at this point in the history

  10. Add back force and refactor 

    This reverts commit 09d82a5.
    @felixhabib
    felixhabib committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    ef2e11e View commit details
    Browse the repository at this point in the history

  11. Always force for typeInSearchField

    @felixhabib
    felixhabib committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    ccd143b View commit details
    Browse the repository at this point in the history

  12. Fix typo

    @felixhabib
    felixhabib committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    f33cd0f View commit details
    Browse the repository at this point in the history

  13. Fix changeset

    @felixhabib
    felixhabib committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    b87ff0a View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Try without waits

    @felixhabib
    felixhabib committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    4517ced View commit details
    Browse the repository at this point in the history

  2. Add wait for jumpToLine only

    @felixhabib
    felixhabib committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    abc2e79 View commit details
    Browse the repository at this point in the history

  3. Add back all waits

    @felixhabib
    felixhabib committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    b49ca5c View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Merge branch 'master' into add-search-replace

    @felixhabib
    felixhabib committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    db25e34 View commit details
    Browse the repository at this point in the history

  2. Remove retries

    @felixhabib
    felixhabib committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e8aceb9 View commit details
    Browse the repository at this point in the history

  3. Rollback typecode change

    @felixhabib
    felixhabib committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    86a597b View commit details
    Browse the repository at this point in the history

  4. Remove assertCodePaneHasFocus 

    Update tests to handle assert in simpler ways
    @felixhabib
    felixhabib committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    84c49ab View commit details
    Browse the repository at this point in the history

  5. Add comment to explain waits

    @felixhabib
    felixhabib committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f6ef488 View commit details
    Browse the repository at this point in the history

  6. Try without force

    @felixhabib
    felixhabib committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    33df989 View commit details
    Browse the repository at this point in the history

  7. Revert "Try without force" 

    This reverts commit 33df989.
    @felixhabib
    felixhabib committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    54100c1 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Fix incorrectly written test

    @felixhabib
    felixhabib committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    3343d81 View commit details
    Browse the repository at this point in the history

  2. Dumbify back out of replace test

    @felixhabib
    felixhabib committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    49b73a0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into add-search-replace

    @felixhabib
    felixhabib committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    3104b96 View commit details
    Browse the repository at this point in the history

  4. Dumbify jumpToLine function

    @felixhabib
    felixhabib committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    c704dff View commit details
    Browse the repository at this point in the history

  5. Format

    @felixhabib
    felixhabib committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    b1ea7c7 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Update changeset 

    Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
    @felixhabib @askoufis
    felixhabib and askoufis authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    40a1243 View commit details
    Browse the repository at this point in the history

  2. Update changeset for brevity and clarity

    @felixhabib
    felixhabib committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    dd21a42 View commit details
    Browse the repository at this point in the history

  3. Ditto

    @felixhabib
    felixhabib committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e44a3d2 View commit details
    Browse the repository at this point in the history