start script: Add fallback browser names to supported browser list
#1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 25b3135 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
AaronMoat
approved these changes
Sep 30, 2024
askoufis
approved these changes
Sep 30, 2024
felixhabib
force-pushed
the
fix-bug-browser-one-tab
branch
from
f3a4f2e
to
25b3135
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug from #1036
Looks like certain instances of Chrome use "Google Chrome" and others "Chrome" as their respective names. "Chrome" was not in the supported browser list and was not being picked up correctly.
Adds both names for fallback purposes to ensure the feature works in more versions. Also giving "Edge" the same treatment.
Have tested locally and appears to be working