Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TypeScript to 5.0, bump babel deps #813

Merged
merged 4 commits into from
May 26, 2023
Merged

Upgrade TypeScript to 5.0, bump babel deps #813

merged 4 commits into from
May 26, 2023

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented May 25, 2023

Always feels weird making a typescript update a minor, but this will be released in a major version anyway so it doesn't really matter.

NOTE: Snapshots are broken until the storybook 7 update is merged in. This is because SB6 doesn't support TS 5.0 because of a removed TypeScript API that's used by an old version of @storybook/react-docgen-typescript-plugin.

@askoufis askoufis requested a review from a team as a code owner May 25, 2023 00:40
@changeset-bot
Copy link

changeset-bot bot commented May 25, 2023

🦋 Changeset detected

Latest commit: 0a51760

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sku Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@askoufis
Copy link
Contributor Author

askoufis commented May 25, 2023

Should we do ~5.0.0 instead of ^5.0.0 (skuba does this) and get in the habit of bumping the typescript version more regularly?

EDIT: Done.

@askoufis askoufis enabled auto-merge (squash) May 26, 2023 07:00
@askoufis askoufis merged commit 828c136 into master May 26, 2023
@askoufis askoufis deleted the typescript5 branch May 26, 2023 07:09
@seek-oss-ci seek-oss-ci mentioned this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants