Make some more of the array types in SkuConfig readonly
#843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ef30d4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
askoufis
approved these changes
Jun 23, 2023
mrm007
reviewed
Jun 23, 2023
| @@ -39,16 +39,16 @@ interface SkuRouteObject { | |||
| route: string; | |||
| name?: string; | |||
| entry?: string; | |||
| languages?: string[]; | |||
| languages?: ReadonlyArray<string>; | |||
There was a problem hiding this comment.
If you prefer the other syntax:
Suggested change
| languages?: ReadonlyArray<string>; | |
| languages?: readonly string[]; |
There was a problem hiding this comment.
Was aiming for consistency with the others here so I know where all my readonlys are
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up while we were doing the country-selection-ui statification work. In order to be able to pass in an array that has been set up with
as const, which you often do so you can use the types elsewhere, the accepting type needs to be readonly.Readonly fields do accept mutable versions of the value, so this doesn't create a problem for any existing consumers.